Enable the revive 'redefines-builtin-id' rule #1230
Merged
+19
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nes-builtin-id # Conflicts: # packages/api/internal/handlers/template_request_build.go
ValentaTomas
approved these changes
Oct 7, 2025
jakubno
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://revive.run/r#redefines-builtin-id
Note
Enables the revive redefines-builtin-id rule and renames identifiers across packages to avoid builtin clashes, plus adds golangci-lint issue limits.
redefines-builtin-id(removed from disabled list in.golangci.yml).issuesconfig withmax-issues-per-linter: 50andmax-same-issues: 50.packages/docker-reverse-proxy/internal/utils/string.go:SubstringMaxparammax->maxLen.packages/orchestrator/internal/sandbox/uffd/userfaultfd/constants.go:NewUffdioCopyparamcopy->bytesCopied.packages/shared/pkg/storage/gcp_multipart.go: backoff func paramsmin/max->start/maxBackoff(propagated in logic).packages/shared/pkg/storage/gcp_multipart_test.go: local varsmax->maxConcurrent/maxObservedin CAS loops.packages/shared/pkg/storage/storage_cache.go: helpercleanupparamclose->fn; updates call sites.min(int64,int64)helper inpackages/orchestrator/internal/sandbox/build/build.go.Written by Cursor Bugbot for commit fdac8ba. This will update automatically on new commits. Configure here.